Skip to content

fix: support customized sse endpoint in WebFluxSseClientTransport #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

fix: support customized sse endpoint in WebFluxSseClientTransport #41

wants to merge 6 commits into from

Conversation

wwulfric
Copy link
Contributor

@wwulfric wwulfric commented Mar 13, 2025 •
edited
Loading

Motivation and Context

Sse endpoint cannot be customized in WebFluxSseClientTransport.

How Has This Been Tested?

Tested in my customized scenario.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

May fix issue #40

@wwulfric wwulfric mentioned this pull request Mar 13, 2025
Closed
@wwulfric
Copy link
Contributor Author

Could it be merged? @tzolov

@tzolov tzolov added this to the 0.9.0 milestone Mar 27, 2025
@tzolov tzolov self-assigned this Mar 27, 2025
@tzolov tzolov added enhancement New feature or request client labels Mar 27, 2025
tzolov added a commit that referenced this pull request Mar 27, 2025
@tzolov @wwulfric @HarryFQG
feat(webflux): Add configurable SSE endpoints to WebFlux transport (#41…
55ee156 
…, #67)

Enhances WebFlux SSE transport implementation with customizable endpoint paths:
- Add configurable SSE endpoint support in both client and server transports
- Update tests to verify custom SSE endpoint functionality
- Implement builder pattern to support the new configuration options

Co-authored-by: haidao <[email protected]>
Co-authored-by: Harry <[email protected]>
Signed-off-by: Christian Tzolov <[email protected]>
@tzolov
Copy link
Contributor

tzolov commented Mar 27, 2025

Thanks @wwulfric I've applied some of your changes in the 55ee156 making you a co-author

@tzolov tzolov closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tzolov tzolov

Labels

client enhancement New feature or request

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@wwulfric @tzolov